Use highp for gpu bezier effects

Use highp for gpu bezier effects

BUG=skia:2860
Committed: https://skia.googlesource.com/skia/+/b2f94d1f4a74f82ea4dd3feb1690ef6d05892afb

[egdaniel, 2014-08-28 21:22:42]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-08-28 21:27:05]

On 2014/08/28 21:22:42, egdaniel wrote:

Does it make anything better?

[bsalomon, 2014-08-28 21:29:19]

https://codereview.chromium.org/519473003/diff/1/src/gpu/gl/builders/GrGLShad...
File src/gpu/gl/builders/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/519473003/diff/1/src/gpu/gl/builders/GrGLShad...
src/gpu/gl/builders/GrGLShaderBuilder.h:100: void declAppend(const
GrGLShaderVar& var, const GrGLProgramBuilder& builder);
Doesn't GrGLShaderBuilder already have getProgramBuilder()?

[egdaniel, 2014-08-29 14:37:20]

On the n10, using highp on conics and quads has negligible effect. For cubics it
removes all the "completely wrong" numerical issues that were present before.
However, some cubics are don't being drawn all the way to their end points and
we end up cutting off part of the cubic.

https://codereview.chromium.org/519473003/diff/1/src/gpu/gl/builders/GrGLShad...
File src/gpu/gl/builders/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/519473003/diff/1/src/gpu/gl/builders/GrGLShad...
src/gpu/gl/builders/GrGLShaderBuilder.h:100: void declAppend(const
GrGLShaderVar& var, const GrGLProgramBuilder& builder);
On 2014/08/28 21:29:19, bsalomon wrote:
> Doesn't GrGLShaderBuilder already have getProgramBuilder()?

yes, removed param

[bsalomon, 2014-08-29 14:55:06]

lgtm

https://codereview.chromium.org/519473003/diff/20001/src/gpu/gl/builders/GrGL...
File src/gpu/gl/builders/GrGLShaderBuilder.cpp (right):

https://codereview.chromium.org/519473003/diff/20001/src/gpu/gl/builders/GrGL...
src/gpu/gl/builders/GrGLShaderBuilder.cpp:68: this->codeAppendf("%s;\n",
tempDecl.c_str());
nit: don't need the \n anymore... we pretty print and ignore the original \n's.

[egdaniel, 2014-08-29 17:01:06]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-08-29 17:02:05]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/519473003/60001

[commit-bot: I haz the power, 2014-08-29 17:08:39]

Committed patchset #4 (id:60001) as b2f94d1f4a74f82ea4dd3feb1690ef6d05892afb