Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 519473002: Implement ct_objects_extractor for OpenSSL. (Closed)

Created:
6 years, 3 months ago by davidben
Modified:
6 years, 3 months ago
Reviewers:
agl, Eran Messeri
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement ct_objects_extractor for OpenSSL. With this, CTObjectsExtractorTest and MultiLogCTVerifierTest pass on OpenSSL builds. BUG=408687 Committed: https://crrev.com/8ea27e621946a33a7337ef84c2307c3dfa0eb4db Cr-Commit-Position: refs/heads/master@{#293235}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update net/BUILD.gn #

Patch Set 4 : Adjust comments (try jobs on previous patch set) #

Patch Set 5 : Another comment tweak (try jobs still on patch set 3) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -12 lines) Patch
M net/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/ct_objects_extractor_openssl.cc View 1 2 3 4 1 chunk +331 lines, -8 lines 1 comment Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
davidben
davidben@chromium.org changed reviewers: + agl@chromium.org
6 years, 3 months ago (2014-08-29 15:23:35 UTC) #1
davidben
Probably you're the best person to review this given all the CBS APIs in use. ...
6 years, 3 months ago (2014-08-29 15:23:35 UTC) #2
davidben
+eranm as reviewer as well.
6 years, 3 months ago (2014-09-02 15:58:19 UTC) #4
Ryan Sleevi
On 2014/09/02 15:58:19, David Benjamin wrote: > +eranm as reviewer as well. ping agl
6 years, 3 months ago (2014-09-03 00:42:20 UTC) #5
agl
lgtm https://codereview.chromium.org/519473002/diff/80001/net/cert/ct_objects_extractor_openssl.cc File net/cert/ct_objects_extractor_openssl.cc (right): https://codereview.chromium.org/519473002/diff/80001/net/cert/ct_objects_extractor_openssl.cc#newcode147 net/cert/ct_objects_extractor_openssl.cc:147: if (!StringEqualToCBS(cert_serial_number, &serial_number)) In some places we remove ...
6 years, 3 months ago (2014-09-03 20:04:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/519473002/80001
6 years, 3 months ago (2014-09-03 20:13:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/519473002/80001
6 years, 3 months ago (2014-09-03 23:23:24 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 74af7a4f320c47c22944a2f50e1ae3b7c12a473c
6 years, 3 months ago (2014-09-04 00:26:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:01 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8ea27e621946a33a7337ef84c2307c3dfa0eb4db
Cr-Commit-Position: refs/heads/master@{#293235}

Powered by Google App Engine
This is Rietveld 408576698