Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 519463003: Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Committed: https://crrev.com/36c364b15726fd8c9dd05ab492ff640bfda861f4 Cr-Commit-Position: refs/heads/master@{#292809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M chrome/installer/gcapi/gcapi.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi_last_run_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/x_privet_token.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M rlz/win/lib/machine_deal_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/fs.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests.
6 years, 3 months ago (2014-08-30 23:43:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/519463003/1
6 years, 3 months ago (2014-08-30 23:43:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23
6 years, 3 months ago (2014-08-30 23:45:19 UTC) #3
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/525013003/ by thakis@chromium.org. ...
6 years, 3 months ago (2014-08-31 17:42:32 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:14:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36c364b15726fd8c9dd05ab492ff640bfda861f4
Cr-Commit-Position: refs/heads/master@{#292809}

Powered by Google App Engine
This is Rietveld 408576698