Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 519453002: Switch security warning font to Roboto if client has it (Closed)

Created:
6 years, 3 months ago by felt
Modified:
5 years, 7 months ago
Reviewers:
Mathieu, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, edwardjung, kenjibaheux
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch security warning font to Roboto if client has it BUG=397717 R=dbeam@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed use of /roboto/ font #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/security_warnings/interstitial_v2.css View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
felt
felt@chromium.org changed reviewers: + mathp@chromium.org
6 years, 3 months ago (2014-08-28 19:33:33 UTC) #1
felt
mathp@, dbeam@, I'm trying to use the new Roboto font that appeared in c/b/resources/roboto recently. ...
6 years, 3 months ago (2014-08-28 19:34:38 UTC) #2
felt
On 2014/08/28 19:34:38, felt wrote: > mathp@, dbeam@, > > I'm trying to use the ...
6 years, 3 months ago (2014-08-28 19:35:10 UTC) #3
Mathieu
Discussed on chat. Since the interstitial is not served from chrome://, it will be difficult ...
6 years, 3 months ago (2014-08-28 20:04:28 UTC) #4
felt
The data: URI thing seems a bit hacky unfortunately. I feel like there's gotta be ...
6 years, 3 months ago (2014-08-28 20:30:57 UTC) #5
felt
6 years, 3 months ago (2014-08-28 20:31:04 UTC) #6
felt
dbeam@ can you review now? in a reviewable state
6 years, 3 months ago (2014-08-29 19:45:39 UTC) #7
Mathieu
lgtm to unblock this...
6 years, 3 months ago (2014-09-03 13:04:07 UTC) #8
Dan Beam
not lgtm - why would these pages be a different font from other chrome pages?
6 years, 3 months ago (2014-09-03 18:52:21 UTC) #9
felt
On 2014/09/03 18:52:21, Dan Beam wrote: > not lgtm - why would these pages be ...
6 years, 3 months ago (2014-09-04 06:19:03 UTC) #10
felt
On 2014/09/04 06:19:03, felt wrote: > On 2014/09/03 18:52:21, Dan Beam wrote: > > not ...
6 years, 3 months ago (2014-09-04 06:19:39 UTC) #11
Dan Beam
did they give a rationale? are we intentionally jarring users with an unfamiliar font?
6 years, 3 months ago (2014-09-05 01:43:30 UTC) #12
felt
6 years, 3 months ago (2014-09-05 07:03:11 UTC) #13 
On 2014/09/05 01:43:30, Dan Beam wrote:
> did they give a rationale?  are we intentionally jarring users with an
> unfamiliar font?

The error page is very minimal so they said the typography ought to be
particularly pretty. I'll double check with them.

Powered by Google App Engine
This is Rietveld 408576698