Cast: merge InsertCoded{Audio,Video}Frame into InsertFrame

Cast: merge InsertCoded{Audio,Video}Frame into InsertFrame

Minor cleanup cl.

Committed: https://crrev.com/2a5280a3431a4110871bfe6427993ffff635da59
Cr-Commit-Position: refs/heads/master@{#293367}

[hubbe, 2014-08-28 19:18:22]

hubbe@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2014-08-28 20:45:29]

lgtm % minor things:

https://codereview.chromium.org/519443002/diff/1/chrome/browser/media/cast_tr...
File chrome/browser/media/cast_transport_host_filter.cc (right):

https://codereview.chromium.org/519443002/diff/1/chrome/browser/media/cast_tr...
chrome/browser/media/cast_transport_host_filter.cc:182: <<
"CastTransportHostFilter::OnInsertCodedAudioFrame "
s/OnInsertCodedAudioFrame/OnInsertFrame/

https://codereview.chromium.org/519443002/diff/1/chrome/common/cast_messages.h
File chrome/common/cast_messages.h (right):

https://codereview.chromium.org/519443002/diff/1/chrome/common/cast_messages....
chrome/common/cast_messages.h:117: CastHostMsg_InitializeAudio,
I wonder if you could do these also?  Or, is there something to untangle first?

https://codereview.chromium.org/519443002/diff/1/media/cast/net/cast_transpor...
File media/cast/net/cast_transport_sender.h (right):

https://codereview.chromium.org/519443002/diff/1/media/cast/net/cast_transpor...
media/cast/net/cast_transport_sender.h:73: // The following function handle the
encoded media frames (audio and
s/handle/handles/

However, perhaps you could fix this comment to be more specific.  Kind of
weird/ambiguous to have a method called InsertFrame() with a comment that says
"it handles encodod frames."

[hubbe, 2014-08-28 22:20:56]

https://codereview.chromium.org/519443002/diff/1/chrome/browser/media/cast_tr...
File chrome/browser/media/cast_transport_host_filter.cc (right):

https://codereview.chromium.org/519443002/diff/1/chrome/browser/media/cast_tr...
chrome/browser/media/cast_transport_host_filter.cc:182: <<
"CastTransportHostFilter::OnInsertCodedAudioFrame "
On 2014/08/28 20:45:29, miu wrote:
> s/OnInsertCodedAudioFrame/OnInsertFrame/

Done.

https://codereview.chromium.org/519443002/diff/1/chrome/common/cast_messages.h
File chrome/common/cast_messages.h (right):

https://codereview.chromium.org/519443002/diff/1/chrome/common/cast_messages....
chrome/common/cast_messages.h:117: CastHostMsg_InitializeAudio,
On 2014/08/28 20:45:29, miu wrote:
> I wonder if you could do these also?  Or, is there something to untangle
first?

Sounds like a great idea for my next CL. :)

https://codereview.chromium.org/519443002/diff/1/media/cast/net/cast_transpor...
File media/cast/net/cast_transport_sender.h (right):

https://codereview.chromium.org/519443002/diff/1/media/cast/net/cast_transpor...
media/cast/net/cast_transport_sender.h:73: // The following function handle the
encoded media frames (audio and
On 2014/08/28 20:45:29, miu wrote:
> s/handle/handles/
> 
> However, perhaps you could fix this comment to be more specific.  Kind of
> weird/ambiguous to have a method called InsertFrame() with a comment that says
> "it handles encodod frames."

Comment updated.

[hubbe, 2014-08-28 22:21:58]

hubbe@chromium.org changed reviewers:
+ tsepez@chromium.org

[hubbe, 2014-08-28 22:21:58]

+tsepez for messages security review

[Tom Sepez, 2014-08-28 22:26:09]

Messages LGTM.

[hubbe, 2014-08-29 02:51:09]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-08-29 02:52:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/519443002/20001

[commit-bot: I haz the power, 2014-08-29 03:09:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47963)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53296)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 03:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 03:10:38]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[hubbe, 2014-08-29 17:47:34]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-08-29 17:48:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/519443002/40001

[commit-bot: I haz the power, 2014-08-29 18:40:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-29 18:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 18:46:06]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hubbe, 2014-09-04 22:22:16]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-09-04 22:25:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/519443002/100001

[commit-bot: I haz the power, 2014-09-04 23:05:41]

Committed patchset #6 (id:100001) as 76302947eaaa2b970c19886cdbb11b239086b4f1

[commit-bot: I haz the power, 2014-09-10 03:33:44]

Patchset 6 (id:??) landed as
https://crrev.com/2a5280a3431a4110871bfe6427993ffff635da59
Cr-Commit-Position: refs/heads/master@{#293367}