Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 519333002: Move resource_loader_bridge.* from webkit/child to content/child. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin (slow to review), Alexander Potapenko, jam, timurrrr+watch_chromium.org, bruening+watch_chromium.org, jamesr, pilgrim_google, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move resource_loader_bridge.* from webkit/child to content/child. This is an intermediate step, the real fix is to get rid of ResourceLoaderBridge. BUG=338338 TEST=None, no functional changes R=avi@chromium.org TBR=darin@chromium.org Committed: https://crrev.com/b6a43eaf7a26a7e6a7a552e2f143855329e93c18 Cr-Commit-Position: refs/heads/master@{#293456}

Patch Set 1 #

Patch Set 2 : add files to content_child.gypi #

Total comments: 2

Patch Set 3 : sort + REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -246 lines) Patch
M BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.h View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
A + content/child/resource_loader_bridge.h View 2 chunks +14 lines, -16 lines 0 comments Download
A + content/child/resource_loader_bridge.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 3 chunks +1 line, -2 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 3 chunks +3 lines, -3 lines 0 comments Download
D webkit/child/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/child/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webkit/child/resource_loader_bridge.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/child/resource_loader_bridge.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/child/webkit_child.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/child/webkit_child_export.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
Avi main reviewer. John, fyi. Hopefully this is fine as an intermediate step.
6 years, 3 months ago (2014-08-30 03:44:18 UTC) #1
Avi (use Gerrit)
lgtm stampity stamp https://codereview.chromium.org/519333002/diff/20001/content/child/resource_dispatcher.h File content/child/resource_dispatcher.h (right): https://codereview.chromium.org/519333002/diff/20001/content/child/resource_dispatcher.h#newcode37 content/child/resource_dispatcher.h:37: class RequestPeer; alphabetize
6 years, 3 months ago (2014-09-02 22:34:36 UTC) #2
tfarina
TBRing Darin for this! https://codereview.chromium.org/519333002/diff/20001/content/child/resource_dispatcher.h File content/child/resource_dispatcher.h (right): https://codereview.chromium.org/519333002/diff/20001/content/child/resource_dispatcher.h#newcode37 content/child/resource_dispatcher.h:37: class RequestPeer; On 2014/09/02 22:34:36, ...
6 years, 3 months ago (2014-09-05 01:07:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/519333002/40001
6 years, 3 months ago (2014-09-05 01:11:48 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 97f52ed0a31eadc3ba2ab86843f60113239e09bf
6 years, 3 months ago (2014-09-05 05:48:55 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:23 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b6a43eaf7a26a7e6a7a552e2f143855329e93c18
Cr-Commit-Position: refs/heads/master@{#293456}

Powered by Google App Engine
This is Rietveld 408576698