Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 519203002: Don't try to use RFH from proxies for subframes. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't try to use RFH from proxies for subframes. BUG=399775 Committed: https://crrev.com/deb60c00378a16b47c83fbccc3521dea8168c3aa Cr-Commit-Position: refs/heads/master@{#292755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
LGTM
6 years, 3 months ago (2014-08-29 23:33:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/519203002/1
6 years, 3 months ago (2014-08-29 23:54:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 01:33:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 49562fcc819c075ea974014a2de7d3b4647f6c4f
6 years, 3 months ago (2014-08-30 01:57:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/deb60c00378a16b47c83fbccc3521dea8168c3aa
Cr-Commit-Position: refs/heads/master@{#292755}

Powered by Google App Engine
This is Rietveld 408576698