Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: ui/events/event_processor.cc

Issue 519113002: Do not mutate ui::Event properties during nested event processing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments changed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/event_processor.h" 5 #include "ui/events/event_processor.h"
6 6
7 #include "ui/events/event_target.h" 7 #include "ui/events/event_target.h"
8 #include "ui/events/event_targeter.h" 8 #include "ui/events/event_targeter.h"
9 9
10 namespace ui { 10 namespace ui {
11 11
12 EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) { 12 EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
13 EventTarget* root = GetRootTarget(); 13 EventTarget* root = GetRootTarget();
14 CHECK(root); 14 CHECK(root);
15 EventTargeter* targeter = root->GetEventTargeter(); 15 EventTargeter* targeter = root->GetEventTargeter();
16 CHECK(targeter); 16 CHECK(targeter);
17 17
18 PrepareEventForDispatch(event); 18 PrepareEventForDispatch(event);
19 EventTarget* target = targeter->FindTargetForEvent(root, event); 19 EventTarget* target = targeter->FindTargetForEvent(root, event);
20 20
21 // If the event is in the process of being dispatched or has already been
22 // dispatched, then dispatch a copy of the event instead.
23 scoped_ptr<Event> event_copy;
24 if (event->phase() != EP_PREDISPATCH)
25 event_copy = Event::Clone(*event);
26
21 while (target) { 27 while (target) {
22 EventDispatchDetails details = DispatchEvent(target, event); 28 EventDispatchDetails details;
29 if (event_copy) {
30 details = DispatchEvent(target, event_copy.get());
31
32 if (event_copy->stopped_propagation())
33 event->StopPropagation();
34 else if (event_copy->handled())
35 event->SetHandled();
36 } else {
37 details = DispatchEvent(target, event);
38 }
39
23 if (details.dispatcher_destroyed || 40 if (details.dispatcher_destroyed ||
24 details.target_destroyed || 41 details.target_destroyed ||
25 event->handled()) { 42 event->handled()) {
26 return details; 43 return details;
27 } 44 }
28 45
29 target = targeter->FindNextBestTarget(target, event); 46 target = targeter->FindNextBestTarget(target, event);
30 } 47 }
31 48
32 return EventDispatchDetails(); 49 return EventDispatchDetails();
33 } 50 }
34 51
35 void EventProcessor::PrepareEventForDispatch(Event* event) { 52 void EventProcessor::PrepareEventForDispatch(Event* event) {
36 } 53 }
37 54
38 } // namespace ui 55 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698