Chromium Code Reviews
Help | Chromium Project | Sign in
(352)

Issue 519090: Changes synchronous session restore to create windows after nested... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by sky
Modified:
2 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Changes synchronous session restore to create windows after nested
message loop returns. The problem with the old approach was we created
a bunch of windows than exited the nested message loop. But because
exit isn't processed immediately it meant someone could also ask for
the nested loop to be exited and then you're hosed (one nested message
loop still running).

BUG=22878
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Lint Patch
M chrome/browser/sessions/session_restore.cc View 6 chunks +19 lines, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
sky
4 years, 3 months ago #1
brettw
4 years, 3 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6