Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 518973002: Remove CanPredictNetworkActionsUI from prediction_options.cc. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove CanPredictNetworkActionsUI from prediction_options.cc. BUG=406586 Committed: https://crrev.com/85ee71025811da9133715ffcbf101512ec0445b9 Cr-Commit-Position: refs/heads/master@{#292940}

Patch Set 1 #

Patch Set 2 : Fix comments in predictor.h. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/net/prediction_options.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/net/prediction_options.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL.
6 years, 3 months ago (2014-08-29 20:54:56 UTC) #2
mmenke
LGTM
6 years, 3 months ago (2014-09-02 15:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/518973002/20001
6 years, 3 months ago (2014-09-02 15:21:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3d30e1e2c5b4d24aba678940479bf5fe873dc07e
6 years, 3 months ago (2014-09-02 16:17:09 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85ee71025811da9133715ffcbf101512ec0445b9
Cr-Commit-Position: refs/heads/master@{#292940}

Powered by Google App Engine
This is Rietveld 408576698