Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 518963002: Add whitelisted permission for access to Universal 2nd Factor devices. (Closed)

Created:
6 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add whitelisted permission for access to Universal 2nd Factor devices. This permission allows an application to access any connected U2F device (as identified by its HID Usage Page) through the chrome.hid API. BUG=374307 Committed: https://crrev.com/667c5595a7326d7e57375afbd2be922dd3a8810f Cr-Commit-Position: refs/heads/master@{#293020}

Patch Set 1 : Remove an unused header. #

Patch Set 2 : Remove unnecessary files. #

Total comments: 2

Patch Set 3 : indates -> indicates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M extensions/browser/api/hid/hid_device_manager.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Reilly Grant (use Gerrit)
6 years, 3 months ago (2014-08-29 18:49:12 UTC) #2
Reilly Grant (use Gerrit)
I was making this too complicated. Removed u2f_devices_permission.*.
6 years, 3 months ago (2014-08-29 20:19:03 UTC) #3
juanlang (chromium.org)
lgtm https://codereview.chromium.org/518963002/diff/40001/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/518963002/diff/40001/extensions/extensions_strings.grd#newcode335 extensions/extensions_strings.grd:335: <message name="IDS_EXTENSION_PROMPT_WARNING_U2F_DEVICES" desc="Warning message which indates that an ...
6 years, 3 months ago (2014-09-02 20:39:50 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/518963002/diff/40001/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/518963002/diff/40001/extensions/extensions_strings.grd#newcode335 extensions/extensions_strings.grd:335: <message name="IDS_EXTENSION_PROMPT_WARNING_U2F_DEVICES" desc="Warning message which indates that an extension ...
6 years, 3 months ago (2014-09-02 20:52:34 UTC) #5
Ken Rockot(use gerrit already)
lgtm, but +meacer: How does the install prompt string look?
6 years, 3 months ago (2014-09-02 21:29:06 UTC) #7
meacer
Install prompt string lgtm. I'm also curious how it'll be localized :)
6 years, 3 months ago (2014-09-02 21:57:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/518963002/60001
6 years, 3 months ago (2014-09-02 22:00:23 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 60910848ac23c070e6fdef383aae143530176247
6 years, 3 months ago (2014-09-02 23:21:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/667c5595a7326d7e57375afbd2be922dd3a8810f
Cr-Commit-Position: refs/heads/master@{#293020}

Powered by Google App Engine
This is Rietveld 408576698