Issue 518903002: Update FontConfig valgrind suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518903002: Update FontConfig valgrind suppressions. (Closed)

Created:
6 years, 3 months ago by bungeman-skia

Modified:
6 years, 3 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Update FontConfig valgrind suppressions. FcPattern uses 'intptr_t elts_offsets' instead of 'FcPatternEltPtr elts' to reference its elements. Therefore, valgrind suspects possible leaks on all values, elements, and element lists in FontConfig. BUG=skia:2879 Committed: https://skia.googlesource.com/skia/+/2210d9e4b2655710c13ef658b84a27f671468bee

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	tools/valgrind.supp	View		1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bungeman-skia

bungeman@google.com changed reviewers: + djsollen@google.com, mtklein@google.com

6 years, 3 months ago (2014-08-29 16:36:07 UTC) #1

bungeman-skia

Hopefully this covers all the 'possible leaks' in FontConfig.

6 years, 3 months ago (2014-08-29 16:36:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/518903002/1

6 years, 3 months ago (2014-08-29 17:26:15 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-29 17:38:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 2210d9e4b2655710c13ef658b84a27f671468bee

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages