Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 518893002: [turbofan] Add/sub ARM64 lhs immediate tests (Closed)

Created:
6 years, 3 months ago by m.m.capewell
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add/sub ARM64 lhs immediate tests Addition supports lhs immediates by commuting. Subtraction supports only zero lhs immediates, through use of the zero register. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +51 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
m.m.capewell
6 years, 3 months ago (2014-08-29 16:54:31 UTC) #2
Benedikt Meurer
lgtm
6 years, 3 months ago (2014-08-29 18:09:20 UTC) #3
m.m.capewell
6 years, 3 months ago (2014-09-01 13:41:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698