Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 518823002: Revert of Restore text alloc optimizations. (Closed)

Created:
6 years, 3 months ago by mtklein
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Restore text alloc optimizations. (patchset #6 of https://codereview.chromium.org/466363009/) Reason for revert: asserts in debug layout tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/21891/steps/webkit_tests/logs/stdio Original issue's description: > Restore text vertex buffer alloc and other optimizations. > > Modifies the fontcache GM to ensure that the font cache is forced to flush. > > Committed: https://skia.googlesource.com/skia/+/9c3d24b9d1ba3d955094ff0cb1ba2d11e1c1adca > > Committed: https://skia.googlesource.com/skia/+/63b9dc82474a4daf195c6157a711be401f7a0ddd TBR=bsalomon@google.com,robertphillips@google.com,jvanverth@google.com NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -164 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/fontcache.cpp View 3 chunks +24 lines, -8 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 12 chunks +82 lines, -66 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 2 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 13 chunks +87 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
Created Revert of Restore text alloc optimizations.
6 years, 3 months ago (2014-08-29 13:56:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/518823002/1
6 years, 3 months ago (2014-08-29 13:57:21 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 13:57:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 13:57:24 UTC) #4
Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:38
  error: expectations/gm/ignored-tests.txt: patch does not apply

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
89d318a5a7d95ec3e50e3db3a5bb329cf97b898e..443626c9c52d0443c31fce307cad14f12d7c2303
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -38,6 +38,3 @@
 
 # reed
 matrixconvolution
-
-# Added as part of https://codereview.chromium.org/466363009/
-fontcache

Powered by Google App Engine
This is Rietveld 408576698