Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 518803009: Move content_settings_pattern and content_settings_pattern_parser to the content_settings component. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-options_chromium.org, dkrahn+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, markusheintz_, mcasas+watch_chromium.org, Michael van Ouwerkerk, nkostylev+watch_chromium.org, oshima+watch_chromium.org, posciak+watch_chromium.org, stevenjb+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move content_settings_pattern and content_settings_pattern_parser to the content_settings component. BUG=387079 TBR=nasko@chromium.org Committed: https://crrev.com/f62dbf9674ab7ad07e58daf40b1e49e3a7ed7b22 Cr-Commit-Position: refs/heads/master@{#293493}

Patch Set 1 #

Patch Set 2 : added forgotten DEPS #

Patch Set 3 : Fix the warning on win #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1231 lines) Patch
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/banners/app_banner_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_custom_extension_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_mock_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_observable_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_rule.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_rule_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/cookie_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/cookie_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_device_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_profile_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/pepper_flash_content_settings_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/content_settings.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/content_settings_pattern.h View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/common/content_settings_pattern.cc View 1 chunk +0 lines, -711 lines 0 comments Download
D chrome/common/content_settings_pattern_parser.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/content_settings_pattern_parser.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M chrome/common/content_settings_pattern_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/content_settings_pattern_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings.gypi View 1 chunk +10 lines, -1 line 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/content_settings/core/common/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/content_settings/core/common/content_settings_pattern.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/common/content_settings_pattern.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + components/content_settings/core/common/content_settings_pattern_parser.h View 2 chunks +8 lines, -5 lines 0 comments Download
A + components/content_settings/core/common/content_settings_pattern_parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
vasilii
Hi guys, please review.
6 years, 3 months ago (2014-09-02 14:52:26 UTC) #2
blundell
On 2014/09/02 14:52:26, vasilii wrote: > Hi guys, > > please review. Did you forget ...
6 years, 3 months ago (2014-09-02 14:56:57 UTC) #3
vasilii
On 2014/09/02 14:56:57, blundell wrote: > On 2014/09/02 14:52:26, vasilii wrote: > > Hi guys, ...
6 years, 3 months ago (2014-09-02 14:59:06 UTC) #4
vabr (Chromium)
LGTM, Thanks!
6 years, 3 months ago (2014-09-02 15:10:23 UTC) #5
blundell
lgtm Thanks!
6 years, 3 months ago (2014-09-02 15:27:32 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 10:22:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/518803009/40001
6 years, 3 months ago (2014-09-04 10:39:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8668)
6 years, 3 months ago (2014-09-04 10:54:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/518803009/40001
6 years, 3 months ago (2014-09-05 08:14:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8932)
6 years, 3 months ago (2014-09-05 08:28:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/518803009/60001
6 years, 3 months ago (2014-09-05 09:23:06 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as c917ee53bcb57cd617b3c9141e66e053e672e3b7
6 years, 3 months ago (2014-09-05 10:24:08 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:35 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f62dbf9674ab7ad07e58daf40b1e49e3a7ed7b22
Cr-Commit-Position: refs/heads/master@{#293493}

Powered by Google App Engine
This is Rietveld 408576698