Chromecast: end-to-end browser test based on content::BrowserTest.

chromecast/shell/browser/cast_browser_main_parts.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_SHELL_BROWSER_CAST_BROWSER_MAIN_PARTS_H_
 #define CHROMECAST_SHELL_BROWSER_CAST_BROWSER_MAIN_PARTS_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/browser_main_parts.h"
-
-namespace content {
-struct MainFunctionParams;
-}
+#include "content/public/common/main_function_params.h"
 
 namespace chromecast {
 namespace shell {
 class CastBrowserProcess;
 class URLRequestContextFactory;
 
 class CastBrowserMainParts : public content::BrowserMainParts {
  public:
   CastBrowserMainParts(
       const content::MainFunctionParams& parameters,
       URLRequestContextFactory* url_request_context_factory);
   virtual ~CastBrowserMainParts();
 
   // content::BrowserMainParts implementation:
   virtual void PreMainMessageLoopStart() OVERRIDE;
   virtual void PostMainMessageLoopStart() OVERRIDE;
   virtual int PreCreateThreads() OVERRIDE;
   virtual void PreMainMessageLoopRun() OVERRIDE;
   virtual bool MainMessageLoopRun(int* result_code) OVERRIDE;
   virtual void PostMainMessageLoopRun() OVERRIDE;
 
  private:
   scoped_ptr<CastBrowserProcess> cast_browser_process_;
 
+  // For running browser tests.
+  const content::MainFunctionParams parameters_;

[lcwu1, 2014/09/08 19:49:15]

The way the data members are broken up and where you place the comment make it
look like both parameters_ and url_request_context_factory_ are both used for
running browser tests. Maybe we should remove the empty line on line 36, or
append the comment on line 37 to line 38.

[gunsch, 2014/09/08 21:34:45]

Done.

   URLRequestContextFactory* const url_request_context_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastBrowserMainParts);
 };
 
 }  // namespace shell
 }  // namespace chromecast
 
 #endif  // CHROMECAST_SHELL_BROWSER_CAST_BROWSER_MAIN_PARTS_H_