Issue 518753002: Add use counter for the firefox extension containsNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518753002: Add use counter for the firefox extension containsNode() (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu

Modified:
6 years, 3 months ago

Reviewers:
yoichio, yosin_UTC9, Yuta Kitamura

CC:
blink-reviews, arv+blink, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Add use counter for the firefox extension containsNode() This is a firefox extension API (https://developer.mozilla.org/En/DOM/Selection). No use counter is present for this API, so adding it here to measure the usage. Bug=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181148

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/editing/Selection.idl	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/frame/UseCounter.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

Sunil Ratnu

sunil.ratnu@samsung.com changed reviewers: + yoichio@chromium.org, yosin@chromium.org, yutak@chromium.org

6 years, 3 months ago (2014-08-29 10:31:18 UTC) #1

Yuta Kitamura

LGTM You are likely to have to update the UseCounter feature ID before committing; please ...

6 years, 3 months ago (2014-09-01 03:55:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/518753002/20001

6 years, 3 months ago (2014-09-01 04:35:58 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-01 05:36:57 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 181148