Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 518753002: Add use counter for the firefox extension containsNode() (Closed)

Created:
6 years, 3 months ago by Sunil Ratnu
Modified:
6 years, 3 months ago
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add use counter for the firefox extension containsNode() This is a firefox extension API (https://developer.mozilla.org/En/DOM/Selection). No use counter is present for this API, so adding it here to measure the usage. Bug=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181148

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/editing/Selection.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Sunil Ratnu
sunil.ratnu@samsung.com changed reviewers: + yoichio@chromium.org, yosin@chromium.org, yutak@chromium.org
6 years, 3 months ago (2014-08-29 10:31:18 UTC) #1
Sunil Ratnu
Please review this. Thanks!
6 years, 3 months ago (2014-08-29 10:31:18 UTC) #2
yosin_UTC9
LGTM Thanks!
6 years, 3 months ago (2014-09-01 00:59:09 UTC) #3
Yuta Kitamura
LGTM You are likely to have to update the UseCounter feature ID before committing; please ...
6 years, 3 months ago (2014-09-01 03:55:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/518753002/20001
6 years, 3 months ago (2014-09-01 04:35:58 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 05:36:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181148

Powered by Google App Engine
This is Rietveld 408576698