Issue 518703003: mojo: Refactor method name generation for java bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518703003: mojo: Refactor method name generation for java bindings. (Closed)

Created:
6 years, 3 months ago by qsr

Modified:
6 years, 3 months ago

Reviewers:
ppi

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Refactor method name generation for java bindings. R=ppi@chromium.org Committed: https://crrev.com/8153db63e249770a2042b86e37b60ded40ecaf4a Cr-Commit-Position: refs/heads/master@{#292610}

Patch Set 1 #

Patch Set 2 : Fix method name. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	mojo/public/tools/bindings/generators/mojom_java_generator.py	View	1	1 chunk	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/518703003/20001

6 years, 3 months ago (2014-08-29 11:26:46 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 1dae4045fd100e20395a745e013088131d6bba1a

6 years, 3 months ago (2014-08-29 12:24:37 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:07:49 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/8153db63e249770a2042b86e37b60ded40ecaf4a
Cr-Commit-Position: refs/heads/master@{#292610}

Expand Messages | Collapse Messages