content/common/view_messages.h - Issue 518693002: Fix a crash when saving a <canvas> or <img> image which is large.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 518693002: Fix a crash when saving a <canvas> or <img> image which is large. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_message_filter.cc ('K') | « content/common/content_constants_internal.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 8e719cfb49b9359ed8fd990dce76a49fe3df9341..9ae56cd66d7fa66b623c55f3b38c385e359eaf3e 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -1200,12 +1200,11 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_AppCacheAccessed,

bool /* blocked by policy */)

// Initiates a download based on user actions like 'ALT+click'.

-IPC_MESSAGE_CONTROL5(ViewHostMsg_DownloadUrl,

+IPC_MESSAGE_CONTROL4(ViewHostMsg_DownloadUrl,

Ken Russell (switch to Gerrit) 2014/09/04 00:23:26 Per other comments, I think this IPC should be lef

zino 2014/09/05 03:47:47 I don't think we need it. It was needed only for "

int /* render_view_id */,

GURL /* url */,

content::Referrer /* referrer */,

- base::string16 /* suggested_name */,

- bool /* use prompt for save location */)

+ base::string16 /* suggested_name */)

// Used to go to the session history entry at the given offset (ie, -1 will

// return the "back" item).

@@ -1343,6 +1342,13 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_EnumerateDirectory,

int /* request_id */,

base::FilePath /* file_path */)

+// Asks the browser to save a image (for <canvas> or <img>) from a data URL.

+// Note: |data_url| is the contents of a data:URL, and that it's represented as

+// a string only to work around size limitations for GURLs in IPC messages.

+IPC_MESSAGE_CONTROL2(ViewHostMsg_SaveImageFromDataURL,

+ int /* render_view_id */,

+ std::string /* data_url */)

// Tells the browser to move the focus to the next (previous if reverse is

// true) focusable element.

IPC_MESSAGE_ROUTED1(ViewHostMsg_TakeFocus,