Fix a crash when saving a <canvas> or <img> image which is large.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 1767 matching lines @@
 void RenderFrameImpl::loadURLExternally(
     blink::WebLocalFrame* frame,
     const blink::WebURLRequest& request,
     blink::WebNavigationPolicy policy,
     const blink::WebString& suggested_name) {
   DCHECK(!frame_ || frame_ == frame);
   Referrer referrer(RenderViewImpl::GetReferrerFromRequest(frame, request));
   if (policy == blink::WebNavigationPolicyDownload) {
     render_view_->Send(new ViewHostMsg_DownloadUrl(render_view_->GetRoutingID(),
                                                    request.url(), referrer,
-                                                   suggested_name, false));
+                                                   suggested_name));
   } else if (policy == blink::WebNavigationPolicyDownloadTo) {
-    render_view_->Send(new ViewHostMsg_DownloadUrl(render_view_->GetRoutingID(),
-                                                   request.url(), referrer,
-                                                   suggested_name, true));
+    render_view_->Send(
+        new ViewHostMsg_SaveImageAs(render_view_->GetRoutingID(),
+                                    request.url().string().utf8(),

[Justin Novosad, 2014/08/29 13:52:32]

So you are just passing the URL as a string to work around the url size limit?
It would be more efficient to pass the binary version of the encoded image,
rather than the data url/base64 version. If that would be a lot more
complicated, then I think this is Okay. This isn't really a performance-critical
area.

[palmer, 2014/08/30 00:37:29]

I agree, just a byte vector is fine.

+                                    referrer, suggested_name));
   } else {
     OpenURL(frame, request.url(), referrer, policy);
   }
 }
 
 blink::WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
     const NavigationPolicyInfo& info) {
   DCHECK(!frame_ || frame_ == info.frame);
   return DecidePolicyForNavigation(this, info);
 }
@@ skipping 1951 matching lines @@
 
 #if defined(ENABLE_BROWSER_CDMS)
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 #endif  // defined(ENABLE_BROWSER_CDMS)
 
 }  // namespace content