Make page switch on drag happen at top and bottom for experimental app list.

Make page switch on drag happen at top and bottom for experimental app list.

This CL makes dragging an app in the experimental app list change pages at
the top and bottom of the apps grid rather than at the sides. This matches
the scroll behavior of the experimental app list.

BUG=406222
Committed: https://crrev.com/2014111cdd73689c693d3b74069919d2d973edfa
Cr-Commit-Position: refs/heads/master@{#293673}

[calamity, 2014-09-02 08:23:56]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-09-02 08:26:34]

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:1657: if
(switches::IsExperimentalAppListEnabled()) {
This should be:

if (pagination_controller_->scroll_axis() ==
PaginationController::SCROLL_AXIS_HORIZONTAL)

for consistency with the other code that is conditional on scroll axis.

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:1658: if (drag_point.y() <
kPageFlipZoneSize)
I'm confused as to why this code is completely different to the horizontal
dragging code?

I mean ... they both seem to get the job done, but why are they different?

[Matt Giuca, 2014-09-03 08:02:18]

lgtm, if you address the one outstanding comment.

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:1658: if (drag_point.y() <
kPageFlipZoneSize)
You explained this to me, so ignore it.

[calamity, 2014-09-03 11:25:36]

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:1657: if
(switches::IsExperimentalAppListEnabled()) {
On 2014/09/02 08:26:34, Matt Giuca wrote:
> This should be:
> 
> if (pagination_controller_->scroll_axis() ==
> PaginationController::SCROLL_AXIS_HORIZONTAL)
> 
> for consistency with the other code that is conditional on scroll axis.

Done.

https://codereview.chromium.org/518673008/diff/20001/ui/app_list/views/apps_g...
ui/app_list/views/apps_grid_view.cc:1658: if (drag_point.y() <
kPageFlipZoneSize)
On 2014/09/03 08:02:18, Matt Giuca wrote:
> You explained this to me, so ignore it.

Acknowledged.

[calamity, 2014-09-03 11:25:53]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-03 11:27:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/518673008/40001

[commit-bot: I haz the power, 2014-09-03 12:20:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-09-03 14:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 14:10:32]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2014-09-08 01:21:19]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-09-08 01:22:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/518673008/40001

[commit-bot: I haz the power, 2014-09-08 01:53:14]

Committed patchset #3 (id:40001) as 7b3fb9e5f9112b1494fcb019c8c7891f1fb6f432

[commit-bot: I haz the power, 2014-09-10 03:44:36]

Patchset 3 (id:??) landed as
https://crrev.com/2014111cdd73689c693d3b74069919d2d973edfa
Cr-Commit-Position: refs/heads/master@{#293673}