Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/resources/options/handler_options_list.js

Issue 518673003: Add policy indicator for protocol handlers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/handler_options_list.js
diff --git a/chrome/browser/resources/options/handler_options_list.js b/chrome/browser/resources/options/handler_options_list.js
index 12129a89a2558610258ed49cc2162e9e3abf4170..789decfe499f6e641ac1de95addb1a401e62f931 100644
--- a/chrome/browser/resources/options/handler_options_list.js
+++ b/chrome/browser/resources/options/handler_options_list.js
@@ -152,15 +152,27 @@ cr.define('options', function() {
this.appendChild(handlerElement);
// Remove link.
- var removeElement = document.createElement('div');
- removeElement.textContent =
- loadTimeData.getString('handlers_remove_link');
- removeElement.addEventListener('click', function(e) {
- var value = selectElement ? selectElement.value : 0;
- delegate.removeHandler(value, data.handlers[value]);
- });
- removeElement.className = 'handlers-remove-column handlers-remove-link';
- this.appendChild(removeElement);
+ if (!data.policy_controlled) {
+ var removeElement = document.createElement('div');
+ removeElement.textContent =
+ loadTimeData.getString('handlers_remove_link');
+ removeElement.addEventListener('click', function(e) {
+ var value = selectElement ? selectElement.value : 0;
+ delegate.removeHandler(value, data.handlers[value]);
+ });
+ removeElement.className =
+ 'handlers-remove-column handlers-remove-link';
+ this.appendChild(removeElement);
+ } else {
+ var indicator = document.createElement('span');
+ indicator.className = 'bubble-button controlled-setting-indicator';
+ indicator.setAttribute('controlled-by', 'hasRecommendation');
bartfab (slow) 2014/08/29 11:23:00 You should send the indicator a fake pref change e
+ var rowDiv = document.createElement('div');
+ rowDiv.setAttribute('tabindex', '0');
+ rowDiv.setAttribute('role', 'button');
+ indicator.appendChild(rowDiv);
+ this.appendChild(indicator);
+ }
},
/** @override */

Powered by Google App Engine
This is Rietveld 408576698