Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: chrome/browser/resources/options/handler_options_list.js

Issue 518673003: Add policy indicator for protocol handlers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds indicator for policy installed protocol handlers Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var List = cr.ui.List; 7 /** @const */ var List = cr.ui.List;
8 /** @const */ var ListItem = cr.ui.ListItem; 8 /** @const */ var ListItem = cr.ui.ListItem;
9 /** @const */ var DeletableItem = options.DeletableItem; 9 /** @const */ var DeletableItem = options.DeletableItem;
10 /** @const */ var DeletableItemList = options.DeletableItemList; 10 /** @const */ var DeletableItemList = options.DeletableItemList;
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 handlerElement.classList.remove('none'); 144 handlerElement.classList.remove('none');
145 delegate.setDefault(data.handlers[index]); 145 delegate.setDefault(data.handlers[index]);
146 } 146 }
147 }); 147 });
148 handlerElement.appendChild(selectElement); 148 handlerElement.appendChild(selectElement);
149 handlerElement.className = 'handlers-site-column'; 149 handlerElement.className = 'handlers-site-column';
150 if (data.default_handler == -1) 150 if (data.default_handler == -1)
151 this.classList.add('none'); 151 this.classList.add('none');
152 this.appendChild(handlerElement); 152 this.appendChild(handlerElement);
153 153
154 // Remove link. 154 // Remove link.
bartfab (slow) 2014/09/01 09:38:37 Nit: Move the comment inside the conditional. It a
155 var removeElement = document.createElement('div'); 155 if (!data.policy_controlled) {
156 removeElement.textContent = 156 var removeElement = document.createElement('div');
157 loadTimeData.getString('handlers_remove_link'); 157 removeElement.textContent =
158 removeElement.addEventListener('click', function(e) { 158 loadTimeData.getString('handlers_remove_link');
159 var value = selectElement ? selectElement.value : 0; 159 removeElement.addEventListener('click', function(e) {
160 delegate.removeHandler(value, data.handlers[value]); 160 var value = selectElement ? selectElement.value : 0;
161 }); 161 delegate.removeHandler(value, data.handlers[value]);
162 removeElement.className = 'handlers-remove-column handlers-remove-link'; 162 });
163 this.appendChild(removeElement); 163 removeElement.className =
164 'handlers-remove-column handlers-remove-link';
165 this.appendChild(removeElement);
166 } else if (data.default_handler != -1) {
167 var indicator = new options.ControlledSettingIndicator();
bartfab (slow) 2014/09/01 09:38:37 Nit: Add a comment that explains this is a policy
168 indicator.controlledBy = 'hasRecommendation';
169 this.appendChild(indicator);
170 }
164 }, 171 },
165 172
166 /** @override */ 173 /** @override */
167 decorate: function() { 174 decorate: function() {
168 ListItem.prototype.decorate.call(this); 175 ListItem.prototype.decorate.call(this);
169 176
170 var delegate = { 177 var delegate = {
171 removeHandler: function(index, handler) { 178 removeHandler: function(index, handler) {
172 chrome.send('removeHandler', [handler]); 179 chrome.send('removeHandler', [handler]);
173 }, 180 },
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 }, 223 },
217 }; 224 };
218 225
219 return { 226 return {
220 IgnoredHandlersListItem: IgnoredHandlersListItem, 227 IgnoredHandlersListItem: IgnoredHandlersListItem,
221 IgnoredHandlersList: IgnoredHandlersList, 228 IgnoredHandlersList: IgnoredHandlersList,
222 HandlerListItem: HandlerListItem, 229 HandlerListItem: HandlerListItem,
223 HandlersList: HandlersList, 230 HandlersList: HandlersList,
224 }; 231 };
225 }); 232 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698