Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: chrome/browser/resources/options/handler_options_list.js

Issue 518673003: Add policy indicator for protocol handlers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var List = cr.ui.List; 7 /** @const */ var List = cr.ui.List;
8 /** @const */ var ListItem = cr.ui.ListItem; 8 /** @const */ var ListItem = cr.ui.ListItem;
9 /** @const */ var DeletableItem = options.DeletableItem; 9 /** @const */ var DeletableItem = options.DeletableItem;
10 /** @const */ var DeletableItemList = options.DeletableItemList; 10 /** @const */ var DeletableItemList = options.DeletableItemList;
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 delegate.setDefault(data.handlers[index]); 145 delegate.setDefault(data.handlers[index]);
146 } 146 }
147 }); 147 });
148 handlerElement.appendChild(selectElement); 148 handlerElement.appendChild(selectElement);
149 handlerElement.className = 'handlers-site-column'; 149 handlerElement.className = 'handlers-site-column';
150 if (data.default_handler == -1) 150 if (data.default_handler == -1)
151 this.classList.add('none'); 151 this.classList.add('none');
152 this.appendChild(handlerElement); 152 this.appendChild(handlerElement);
153 153
154 // Remove link. 154 // Remove link.
155 var removeElement = document.createElement('div'); 155 if (!data.policy_controlled) {
156 removeElement.textContent = 156 var removeElement = document.createElement('div');
157 loadTimeData.getString('handlers_remove_link'); 157 removeElement.textContent =
158 removeElement.addEventListener('click', function(e) { 158 loadTimeData.getString('handlers_remove_link');
159 var value = selectElement ? selectElement.value : 0; 159 removeElement.addEventListener('click', function(e) {
160 delegate.removeHandler(value, data.handlers[value]); 160 var value = selectElement ? selectElement.value : 0;
161 }); 161 delegate.removeHandler(value, data.handlers[value]);
162 removeElement.className = 'handlers-remove-column handlers-remove-link'; 162 });
163 this.appendChild(removeElement); 163 removeElement.className =
164 'handlers-remove-column handlers-remove-link';
165 this.appendChild(removeElement);
166 } else {
167 var indicator = document.createElement('span');
168 indicator.className = 'bubble-button controlled-setting-indicator';
169 indicator.setAttribute('controlled-by', 'hasRecommendation');
bartfab (slow) 2014/08/29 11:23:00 You should send the indicator a fake pref change e
170 var rowDiv = document.createElement('div');
171 rowDiv.setAttribute('tabindex', '0');
172 rowDiv.setAttribute('role', 'button');
173 indicator.appendChild(rowDiv);
174 this.appendChild(indicator);
175 }
164 }, 176 },
165 177
166 /** @override */ 178 /** @override */
167 decorate: function() { 179 decorate: function() {
168 ListItem.prototype.decorate.call(this); 180 ListItem.prototype.decorate.call(this);
169 181
170 var delegate = { 182 var delegate = {
171 removeHandler: function(index, handler) { 183 removeHandler: function(index, handler) {
172 chrome.send('removeHandler', [handler]); 184 chrome.send('removeHandler', [handler]);
173 }, 185 },
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 }, 228 },
217 }; 229 };
218 230
219 return { 231 return {
220 IgnoredHandlersListItem: IgnoredHandlersListItem, 232 IgnoredHandlersListItem: IgnoredHandlersListItem,
221 IgnoredHandlersList: IgnoredHandlersList, 233 IgnoredHandlersList: IgnoredHandlersList,
222 HandlerListItem: HandlerListItem, 234 HandlerListItem: HandlerListItem,
223 HandlersList: HandlersList, 235 HandlersList: HandlersList,
224 }; 236 };
225 }); 237 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698