| Index: chrome/browser/extensions/extension_tab_util.cc
|
| diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
|
| index ffc2b9527c5877835bafd76ae06c0ea281e542a6..37fa9ecdaca8481be20c28bbb9a7a202f625a6da 100644
|
| --- a/chrome/browser/extensions/extension_tab_util.cc
|
| +++ b/chrome/browser/extensions/extension_tab_util.cc
|
| @@ -22,7 +22,6 @@
|
| #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
|
| #include "chrome/browser/ui/tabs/tab_strip_model.h"
|
| #include "chrome/common/extensions/api/tabs.h"
|
| -#include "chrome/common/extensions/manifest_url_handler.h"
|
| #include "chrome/common/url_constants.h"
|
| #include "components/url_fixer/url_fixer.h"
|
| #include "content/public/browser/favicon_status.h"
|
| @@ -36,6 +35,7 @@
|
| #include "extensions/common/feature_switch.h"
|
| #include "extensions/common/manifest_constants.h"
|
| #include "extensions/common/manifest_handlers/incognito_info.h"
|
| +#include "extensions/common/manifest_handlers/options_page_info.h"
|
| #include "extensions/common/permissions/api_permission.h"
|
| #include "extensions/common/permissions/permissions_data.h"
|
| #include "url/gurl.h"
|
| @@ -556,7 +556,7 @@ WindowController* ExtensionTabUtil::GetWindowControllerOfTab(
|
|
|
| void ExtensionTabUtil::OpenOptionsPage(const Extension* extension,
|
| Browser* browser) {
|
| - DCHECK(!ManifestURL::GetOptionsPage(extension).is_empty());
|
| + DCHECK(OptionsPageInfo::HasOptionsPage(extension));
|
|
|
| // Force the options page to open in non-OTR window, because it won't be
|
| // able to save settings from OTR.
|
| @@ -568,7 +568,7 @@ void ExtensionTabUtil::OpenOptionsPage(const Extension* extension,
|
| browser = displayer->browser();
|
| }
|
|
|
| - if (FeatureSwitch::embedded_extension_options()->IsEnabled()) {
|
| + if (!OptionsPageInfo::ShouldOpenInTab(extension)) {
|
| // If embedded extension options are enabled, open chrome://extensions
|
| // in a new tab and show the extension options in an embedded popup.
|
| chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
|
| @@ -584,7 +584,7 @@ void ExtensionTabUtil::OpenOptionsPage(const Extension* extension,
|
| chrome::ShowSingletonTabOverwritingNTP(browser, params);
|
| } else {
|
| // Otherwise open a new tab with the extension's options page
|
| - content::OpenURLParams params(ManifestURL::GetOptionsPage(extension),
|
| + content::OpenURLParams params(OptionsPageInfo::GetOptionsPage(extension),
|
| content::Referrer(),
|
| SINGLETON_TAB,
|
| content::PAGE_TRANSITION_LINK,
|
|
|