Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/common/extensions/manifest_url_handler.h

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build issue? Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_handler.h
diff --git a/chrome/common/extensions/manifest_url_handler.h b/chrome/common/extensions/manifest_url_handler.h
index 98786842671da153c4aa570ad9ef62a51cab9ee6..bf5f835c627dc5dc46f91d0b9ab1b43449836a6d 100644
--- a/chrome/common/extensions/manifest_url_handler.h
+++ b/chrome/common/extensions/manifest_url_handler.h
@@ -41,9 +41,6 @@ struct ManifestURL : public Extension::ManifestData {
static bool UpdatesFromGallery(const Extension* extension);
static bool UpdatesFromGallery(const base::DictionaryValue* manifest);
- // Returns the Options Page for this extension.
- static const GURL& GetOptionsPage(const Extension* extension);
-
// Returns the About Page for this extension.
static const GURL& GetAboutPage(const Extension* extension);
@@ -110,23 +107,6 @@ class UpdateURLHandler : public ManifestHandler {
DISALLOW_COPY_AND_ASSIGN(UpdateURLHandler);
};
-// Parses the "options_page" manifest key.
-class OptionsPageHandler : public ManifestHandler {
- public:
- OptionsPageHandler();
- virtual ~OptionsPageHandler();
-
- virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;
- virtual bool Validate(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings) const OVERRIDE;
-
- private:
- virtual const std::vector<std::string> Keys() const OVERRIDE;
-
- DISALLOW_COPY_AND_ASSIGN(OptionsPageHandler);
-};
-
// Parses the "about_page" manifest key.
// TODO(sashab): Make this and any other similar handlers extend from the same
// abstract class, URLManifestHandler, which has pure virtual methods for

Powered by Google App Engine
This is Rietveld 408576698