chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build issue? Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/chrome_manifest_handlers.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 81fc7c1e0cafb5e86ceaa505ba4b0d38ce5bcd4d..51c648ba31934ffabc43dcf34d1946454ba51c50 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -8,10 +8,10 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

-#include "chrome/common/extensions/manifest_url_handler.h"

#include "components/crx_file/id_util.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/switches.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/base/l10n/l10n_util.h"

@@ -119,9 +119,9 @@ TEST_F(InitValueManifestTest, InitFromValueValid) {

// Test with an options page.

extension = LoadAndExpectSuccess("init_valid_options.json");

EXPECT_EQ("chrome-extension",

- ManifestURL::GetOptionsPage(extension.get()).scheme());

+ OptionsPageInfo::GetOptionsPage(extension.get()).scheme());

EXPECT_EQ("/options.html",

- ManifestURL::GetOptionsPage(extension.get()).path());

+ OptionsPageInfo::GetOptionsPage(extension.get()).path());

// Test optional short_name field.

extension = LoadAndExpectSuccess("init_valid_short_name.json");