chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build issue? Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

index cbf79326c1a80ada265080d3b35c6e4fcb5b2a6d..0efcb9d4be6f703d6089d2f26743a9ee7d92266b 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

@@ -32,6 +32,7 @@

#include "extensions/browser/extension_system.h"

#include "extensions/browser/uninstall_reason.h"

#include "extensions/common/extension.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

#include "ui/base/l10n/l10n_util_mac.h"

using content::OpenURLParams;

@@ -134,7 +135,7 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

action:@selector(onOptions:)

keyEquivalent:@""];

[item setTarget:self];

- [item setEnabled:extensions::ManifestURL::GetOptionsPage(

+ [item setEnabled:extensions::OptionsPageInfo::GetOptionsPage(

extension_).spec().length() > 0];

@@ -198,7 +199,7 @@ class AsyncUninstaller : public extensions::ExtensionUninstallDialog::Delegate {

}

- (void)onOptions:(id)sender {

- DCHECK(!extensions::ManifestURL::GetOptionsPage(extension_).is_empty());

+ DCHECK(!extensions::OptionsPageInfo::GetOptionsPage(extension_).is_empty());

extensions::ExtensionTabUtil::OpenOptionsPage(extension_, browser_);

}

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »