chrome/common/extensions/chrome_manifest_handlers.cc - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_handlers.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flag logic and define directive Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/chrome_manifest_handlers.cc

diff --git a/chrome/common/extensions/chrome_manifest_handlers.cc b/chrome/common/extensions/chrome_manifest_handlers.cc

index 013fab272ea53be3bdce31d4cf7c14e720b8f6e7..93dd8d37f52e22dab42a0a1b5a7ec6528db5225d 100644

--- a/chrome/common/extensions/chrome_manifest_handlers.cc

+++ b/chrome/common/extensions/chrome_manifest_handlers.cc

@@ -35,6 +35,7 @@

#include "extensions/common/api/bluetooth/bluetooth_manifest_handler.h"

#include "extensions/common/api/sockets/sockets_manifest_handler.h"

#include "extensions/common/manifest_handlers/externally_connectable.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

#include "extensions/common/manifest_handlers/requirements_info.h"

namespace extensions {

@@ -62,7 +63,7 @@ void RegisterChromeManifestHandlers() {

(new MinimumChromeVersionChecker)->Register();

(new OAuth2ManifestHandler)->Register();

(new OmniboxHandler)->Register();

- (new OptionsPageHandler)->Register();

+ (new OptionsPageManifestHandler)->Register();

(new PageActionHandler)->Register();

(new PluginsHandler)->Register();

(new RequirementsHandler)->Register(); // Depends on plugins.