chrome/browser/ui/webui/extensions/extension_basic_info.cc - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_basic_info.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flag logic and define directive Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_basic_info.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_basic_info.cc b/chrome/browser/ui/webui/extensions/extension_basic_info.cc

index 67fe09af877c376405fca60829d56a884e59c276..768e2fda6f989d46788d16d4992607825c42f0f8 100644

--- a/chrome/browser/ui/webui/extensions/extension_basic_info.cc

+++ b/chrome/browser/ui/webui/extensions/extension_basic_info.cc

@@ -9,6 +9,7 @@

#include "extensions/common/extension.h"

#include "extensions/common/manifest_handlers/kiosk_mode_info.h"

#include "extensions/common/manifest_handlers/offline_enabled_info.h"

+#include "extensions/common/manifest_handlers/options_page_info.h"

namespace {

@@ -46,7 +47,7 @@ void GetExtensionBasicInfo(const Extension* extension,

info->SetString(kDescriptionKey, extension->description());

info->SetString(

kOptionsUrlKey,

- ManifestURL::GetOptionsPage(extension).possibly_invalid_spec());

+ OptionsPageInfo::GetOptionsPage(extension).possibly_invalid_spec());

info->SetString(

kHomepageUrlKey,

ManifestURL::GetHomepageURL(extension).possibly_invalid_spec());