chrome/browser/resources/extensions/extension_list.js - Issue 518653002: Add the "options_ui" extension manifest field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix flag logic and define directive Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index f7e0b083cdb589534785a25c90fa35d19807a5db..60ef2f51ac1a052cb0d172b64232135da7c8e354 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -272,7 +272,7 @@ cr.define('options', function() {

if (extension.enabled && extension.optionsUrl) {

var options = node.querySelector('.options-link');

options.addEventListener('click', function(e) {

- if (this.data_.enableEmbeddedExtensionOptions) {

+ if (!extension.options_open_in_tab) {

Devlin 2014/09/02 21:42:29 nit: no unix_hacker_style in js.

ericzeng 2014/09/03 17:52:13 Done.

this.showEmbeddedExtensionOptions_(extension.id, false);

} else {

chrome.send('extensionSettingsOptions', [extension.id]);