Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 87f8a3f36844f54f833d0421a7037ae9a4f32f73..85d5bf6d5ef5b140773c1db4c21cffc839ed250e 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -92,6 +92,7 @@
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "extensions/common/manifest_handlers/incognito_info.h"
+#include "extensions/common/manifest_handlers/options_page_info.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/switches.h"
#include "grit/browser_resources.h"
@@ -270,6 +271,10 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
extension_data->SetBoolean("is_platform_app", extension->is_platform_app());
extension_data->SetBoolean("homepageProvided",
ManifestURL::GetHomepageURL(extension).is_valid());
+ extension_data->SetBoolean("options_chrome_style",
not at google - send to devlin 2014/08/29 05:39:23 When would you need to access this?
ericzeng 2014/08/29 16:52:22 I'm not sure, if the UA stylesheet is handled all
ericzeng 2014/08/29 22:08:50 Done.
+ OptionsPageInfo::ChromeStyle(extension));
+ extension_data->SetBoolean("options_open_in_tab",
+ OptionsPageInfo::OpenInTab(extension));
// Add dependent extensions.
base::ListValue* dependents_list = new base::ListValue;
@@ -1125,7 +1130,7 @@ void ExtensionSettingsHandler::HandleUninstallMessage(
void ExtensionSettingsHandler::HandleOptionsMessage(
const base::ListValue* args) {
const Extension* extension = GetActiveExtension(args);
- if (!extension || ManifestURL::GetOptionsPage(extension).is_empty())
+ if (!extension || OptionsPageInfo::GetOptionsPage(extension).is_empty())
return;
ExtensionTabUtil::OpenOptionsPage(extension,
chrome::FindBrowserWithWebContents(web_ui()->GetWebContents()));

Powered by Google App Engine
This is Rietveld 408576698