Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 518653002: Add the "options_ui" extension manifest field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index f7e0b083cdb589534785a25c90fa35d19807a5db..acdfd7e1792b059bc153fa1920a39b954c4abdb2 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -272,7 +272,8 @@ cr.define('options', function() {
if (extension.enabled && extension.optionsUrl) {
var options = node.querySelector('.options-link');
options.addEventListener('click', function(e) {
- if (this.data_.enableEmbeddedExtensionOptions) {
+ if (this.data_.enableEmbeddedExtensionOptions &&
not at google - send to devlin 2014/08/29 05:39:23 The flag check should be unnecessary now, so long
ericzeng 2014/08/29 16:52:22 Hold your horses, I haven't removed the feature fl
ericzeng 2014/08/29 22:08:49 Done.
+ !extension.options_open_in_tab) {
this.showEmbeddedExtensionOptions_(extension.id, false);
} else {
chrome.send('extensionSettingsOptions', [extension.id]);

Powered by Google App Engine
This is Rietveld 408576698