Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 518643002: Add ability to pass decryption key id to CreateSecureMessage method (Closed)

Created:
6 years, 3 months ago by tbarzic
Modified:
6 years, 3 months ago
Reviewers:
xiyuan, stevenjb, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ability to pass decryption key id to CreateSecureMessage method This should enable the message receiver to identify a key to be used for message decryption. BUG=409099 (depends on https://codereview.chromium.org/513013003/) Committed: https://crrev.com/042e34f6e87e2305400035976511ca4987383f37 Cr-Commit-Position: refs/heads/master@{#293006}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Total comments: 1

Messages

Total messages: 15 (4 generated)
tbarzic
xiyuan: c/b/e/api/easy_unlock_private yoz: owner for easy_unlock_private.idl stevenjb: owner for chromeos/
6 years, 3 months ago (2014-08-29 18:58:01 UTC) #2
Yoyo Zhou
IDL lgtm https://codereview.chromium.org/518643002/diff/20001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/518643002/diff/20001/chrome/common/extensions/api/easy_unlock_private.idl#newcode85 chrome/common/extensions/api/easy_unlock_private.idl:85: // Decryption key id added to the ...
6 years, 3 months ago (2014-08-29 18:59:45 UTC) #3
xiyuan
lgtm
6 years, 3 months ago (2014-08-29 19:06:14 UTC) #4
tbarzic
https://codereview.chromium.org/518643002/diff/20001/chrome/common/extensions/api/easy_unlock_private.idl File chrome/common/extensions/api/easy_unlock_private.idl (right): https://codereview.chromium.org/518643002/diff/20001/chrome/common/extensions/api/easy_unlock_private.idl#newcode85 chrome/common/extensions/api/easy_unlock_private.idl:85: // Decryption key id added to the message header. ...
6 years, 3 months ago (2014-08-29 19:14:53 UTC) #5
stevenjb
owner lgtm https://codereview.chromium.org/518643002/diff/40001/chromeos/dbus/easy_unlock_client.h File chromeos/dbus/easy_unlock_client.h (right): https://codereview.chromium.org/518643002/diff/40001/chromeos/dbus/easy_unlock_client.h#newcode81 chromeos/dbus/easy_unlock_client.h:81: const DataCallback& callback) = 0; nit: For ...
6 years, 3 months ago (2014-09-02 16:09:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/518643002/40001
6 years, 3 months ago (2014-09-02 17:27:31 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-09-02 18:24:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/7957)
6 years, 3 months ago (2014-09-02 19:27:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/518643002/40001
6 years, 3 months ago (2014-09-02 21:24:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 3fd4f05d7aa11c8ac1aaf86d9c026ebad3ba5f06
6 years, 3 months ago (2014-09-02 22:11:21 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/042e34f6e87e2305400035976511ca4987383f37
Cr-Commit-Position: refs/heads/master@{#293006}

Powered by Google App Engine
This is Rietveld 408576698