Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 518633002: Remove fake UserGestureIndicator from WebLocalFrameImpl (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove fake UserGestureIndicator from WebLocalFrameImpl This CL removes the old code needed to make the blink roll happen properly. This is part 3 of 3, depends on: https://codereview.chromium.org/518583003/ BUG=408426, 406336 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Zeeshan Qureshi
James PTAL
6 years, 3 months ago (2014-08-29 19:20:01 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-03 21:22:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/518633002/1
6 years, 3 months ago (2014-09-04 21:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/518633002/1
6 years, 3 months ago (2014-09-04 21:45:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/518633002/1
6 years, 3 months ago (2014-09-04 22:47:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/518633002/1
6 years, 3 months ago (2014-09-09 17:40:45 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 17:41:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181660

Powered by Google App Engine
This is Rietveld 408576698