Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: media/filters/renderer_impl.cc

Issue 518613002: Have AudioRendererImpl advance time until it's told to stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix & rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/renderer_impl.cc
diff --git a/media/filters/renderer_impl.cc b/media/filters/renderer_impl.cc
index f7dee3299d773d1549624f658d972f9a7c8eac4e..1e5cb18048d869a00340df0aded69d8aab232547 100644
--- a/media/filters/renderer_impl.cc
+++ b/media/filters/renderer_impl.cc
@@ -501,14 +501,6 @@ void RendererImpl::OnAudioRendererEnded() {
DCHECK(!audio_ended_);
audio_ended_ = true;
- // Start clock since there is no more audio to trigger clock updates.
- {
- base::TimeDelta duration = get_duration_cb_.Run();
- base::AutoLock auto_lock(interpolator_lock_);
- interpolator_->SetUpperBound(duration);
- StartClockIfWaitingForTimeUpdate_Locked();
- }
-
RunEndedCallbackIfNeeded();
}
@@ -536,10 +528,8 @@ void RendererImpl::RunEndedCallbackIfNeeded() {
return;
{
- base::TimeDelta duration = get_duration_cb_.Run();
base::AutoLock auto_lock(interpolator_lock_);
PauseClockAndStopTicking_Locked();
- interpolator_->SetBounds(duration, duration);
}
ended_cb_.Run();

Powered by Google App Engine
This is Rietveld 408576698