Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: media/filters/renderer_impl_unittest.cc

Issue 518613002: Have AudioRendererImpl advance time until it's told to stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/renderer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/renderer_impl_unittest.cc
diff --git a/media/filters/renderer_impl_unittest.cc b/media/filters/renderer_impl_unittest.cc
index 42bf97d4611a7997e89c34ce56d2ce3c37954521..8edc1202e82c6b7f4cf829984281e35fb7b77b4d 100644
--- a/media/filters/renderer_impl_unittest.cc
+++ b/media/filters/renderer_impl_unittest.cc
@@ -401,34 +401,6 @@ TEST_F(RendererImplTest, GetMediaTime) {
EXPECT_EQ(kAudioUpdateMaxTimeMs, GetMediaTimeMs());
}
-TEST_F(RendererImplTest, AudioStreamShorterThanVideo) {
- // Replace what's used for interpolating to simulate wall clock time.
- renderer_impl_->SetTimeDeltaInterpolatorForTesting(
- new TimeDeltaInterpolator(&test_tick_clock_));
-
- InitializeWithAudioAndVideo();
- Play();
-
- EXPECT_EQ(kStartPlayingTimeInMs, GetMediaTimeMs());
-
- // Verify that the clock doesn't advance since it hasn't been started by
- // a time update from the audio stream.
- EXPECT_FALSE(IsMediaTimeAdvancing());
-
- // Signal end of audio stream.
- audio_ended_cb_.Run();
- base::RunLoop().RunUntilIdle();
-
- // Verify that the clock advances.
- EXPECT_TRUE(IsMediaTimeAdvancing());
-
- // Signal end of video stream and make sure OnEnded() callback occurs.
- EXPECT_CALL(time_source_, StopTicking());
- EXPECT_CALL(callbacks_, OnEnded());
- video_ended_cb_.Run();
- base::RunLoop().RunUntilIdle();
-}
-
TEST_F(RendererImplTest, AudioTimeUpdateDuringFlush) {
// Replace what's used for interpolating to simulate wall clock time.
renderer_impl_->SetTimeDeltaInterpolatorForTesting(
« no previous file with comments | « media/filters/renderer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698