content/renderer/render_frame_impl.h - Issue 518583003: Don't take a fake UGI every time we execute Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 518583003: Don't take a fake UGI every time we execute Javascript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test expectation Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/public/test/browser_test_utils.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 9fc05417c912928330233b1b6872a0f3333cc4d4..2e21207a80e7d42e365679087b1e59e1429226e9 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -517,6 +517,13 @@ class CONTENT_EXPORT RenderFrameImpl

void OnJavaScriptExecuteRequest(const base::string16& javascript,

int id,

bool notify_result);

+ void OnJavaScriptExecuteRequestForTests(const base::string16& javascript,

+ int id,

+ bool notify_result);

+ void HandleJavascriptExecutionResult(const base::string16& javascript,

jamesr 2014/09/03 20:22:11 this is not an IPC message handler. please move it

Zeeshan Qureshi 2014/09/03 21:18:09 Done.

+ int id,

+ bool notify_result,

+ v8::Handle<v8::Value> result);

void OnSetEditableSelectionOffsets(int start, int end);

void OnSetCompositionFromExistingText(

int start, int end,