chrome/browser/prerender/prerender_browsertest.cc - Issue 518583003: Don't take a fake UGI every time we execute Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 518583003: Don't take a fake UGI every time we execute Javascript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test expectation Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_installer_test.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_browsertest.cc

diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc

index f5aa34701806700cbf3220442c4ad80d8f241f23..112ac69d35909ca9bf1f4900887dbab8d7e2607f 100644

--- a/chrome/browser/prerender/prerender_browsertest.cc

+++ b/chrome/browser/prerender/prerender_browsertest.cc

@@ -1632,7 +1632,8 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {

if (new_web_contents) {

NewTabNavigationOrSwapObserver observer;

- render_frame_host->ExecuteJavaScript(base::ASCIIToUTF16(javascript));

+ render_frame_host->

+ ExecuteJavaScriptForTests(base::ASCIIToUTF16(javascript));

observer.Wait();

} else {

NavigationOrSwapObserver observer(current_browser()->tab_strip_model(),