content/public/test/browser_test_utils.cc - Issue 518583003: Don't take a fake UGI every time we execute Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/browser_test_utils.cc

Issue 518583003: Don't take a fake UGI every time we execute Javascript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix styling Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/browser_test_utils.cc

diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc

index a19331b5cd02916d45148f003b4375307ba4e8cd..97d01375b729101504e08ea93fb80d5bd6df55b9 100644

--- a/content/public/test/browser_test_utils.cc

+++ b/content/public/test/browser_test_utils.cc

@@ -109,7 +109,7 @@ bool ExecuteScriptHelper(RenderFrameHost* render_frame_host,

std::string script =

"window.domAutomationController.setAutomationId(0);" + original_script;

DOMOperationObserver dom_op_observer(render_frame_host->GetRenderViewHost());

- render_frame_host->ExecuteJavaScript(base::UTF8ToUTF16(script));

+ render_frame_host->ExecuteJavaScriptForTests(base::UTF8ToUTF16(script));

std::string json;

if (!dom_op_observer.WaitAndGetResponse(&json)) {

DLOG(ERROR) << "Cannot communicate with DOMOperationObserver.";

« no previous file with comments | « content/public/browser/render_frame_host.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »