chrome/browser/extensions/webstore_installer_test.cc - Issue 518583003: Don't take a fake UGI every time we execute Javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer_test.cc

Issue 518583003: Don't take a fake UGI every time we execute Javascript. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix styling Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/webstore_installer_test.cc

diff --git a/chrome/browser/extensions/webstore_installer_test.cc b/chrome/browser/extensions/webstore_installer_test.cc

index 63fc4e0ebc8438286c0c5c5fde8d61da9da0c0a5..33329d06479f98e40b8d6103c533a02be9e44444 100644

--- a/chrome/browser/extensions/webstore_installer_test.cc

+++ b/chrome/browser/extensions/webstore_installer_test.cc

@@ -131,7 +131,7 @@ void WebstoreInstallerTest::RunTestAsync(

std::string script = base::StringPrintf(

"%s('%s')", test_function_name.c_str(), test_gallery_url_.c_str());

browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame()->

- ExecuteJavaScript(base::UTF8ToUTF16(script));

+ ExecuteJavaScriptForTests(base::UTF8ToUTF16(script));

}

void WebstoreInstallerTest::AutoAcceptInstall() {

« no previous file with comments | « chrome/browser/extensions/extension_messages_apitest.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »