Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 518543004: Various GN fixes. (Closed)

Created:
6 years, 3 months ago by DaleCurtis
Modified:
6 years, 3 months ago
Reviewers:
jamesr, brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Various GN fixes. - Fixes gcc_version issues on gTrusty. - Fixes accidental duplicate in input_events build file. - Fixes spammy warnings in libxml. BUG=none TEST=builds Committed: https://crrev.com/54d9265014bce6db79a5a0364031e29e031c8d26 Cr-Commit-Position: refs/heads/master@{#292669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/config/gcc/gcc_version.gni View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
DaleCurtis
dalecurtis@chromium.org changed reviewers: + brettw@chromium.org
6 years, 3 months ago (2014-08-28 23:05:20 UTC) #1
DaleCurtis
6 years, 3 months ago (2014-08-28 23:05:21 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-08-29 16:15:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/518543004/1
6 years, 3 months ago (2014-08-29 17:02:18 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 18:04:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7714)
6 years, 3 months ago (2014-08-29 18:08:19 UTC) #8
DaleCurtis
+jamesr for mojo
6 years, 3 months ago (2014-08-29 18:10:21 UTC) #10
jamesr
lgtm
6 years, 3 months ago (2014-08-29 18:18:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/518543004/1
6 years, 3 months ago (2014-08-29 18:22:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as cd8c43eeef1f335eacd108b544e403df98135314
6 years, 3 months ago (2014-08-29 18:28:02 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54d9265014bce6db79a5a0364031e29e031c8d26
Cr-Commit-Position: refs/heads/master@{#292669}

Powered by Google App Engine
This is Rietveld 408576698