Handle incorrect promise resolving

Handle incorrect promise resolving

Due to an issue in the CDM, when a session to be loaded is not
found, the CDM calls PromiseResolve() instead of the expected
PromiseResolveWithSession(""). This change detects this situation
and handles it properly.

BUG=408337
TEST=existing EME tests pass

Committed: https://crrev.com/fd0069d61b1f3281a2634bf907a96bebee7fb396
Cr-Commit-Position: refs/heads/master@{#292497}

[jrummell, 2014-08-28 20:26:04]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2014-08-28 20:26:04]

PTAL.

[xhwang, 2014-08-28 20:33:51]

lgtm

https://codereview.chromium.org/518523002/diff/1/content/renderer/pepper/cont...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/518523002/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:631: //
PromiseResolvedWithSession(""), so emulate that here until 408330 is fixed.
nit: add a TODO so that we don't forget to remove this.

[jrummell, 2014-08-28 21:26:27]

jrummell@chromium.org changed reviewers:
+ bbudge@chromium.org

[jrummell, 2014-08-28 21:26:27]

+bbudge@ for OWNERS review

https://codereview.chromium.org/518523002/diff/1/content/renderer/pepper/cont...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/518523002/diff/1/content/renderer/pepper/cont...
content/renderer/pepper/content_decryptor_delegate.cc:631: //
PromiseResolvedWithSession(""), so emulate that here until 408330 is fixed.
On 2014/08/28 20:33:51, xhwang wrote:
> nit: add a TODO so that we don't forget to remove this.

Done.

[bbudge, 2014-08-28 21:41:41]

One nit, otherwise LGTM

https://codereview.chromium.org/518523002/diff/20001/content/renderer/pepper/...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/518523002/diff/20001/content/renderer/pepper/...
content/renderer/pepper/content_decryptor_delegate.cc:636:
static_cast<NewSessionCdmPromise*>(promise.get()));
nit: The assignment syntax seems more common in Chrome: i.e.

NewSessionCdmPromise* session_promise =
    static_cast< ...

[jrummell, 2014-08-28 21:52:24]

Thanks for the reviews.

https://codereview.chromium.org/518523002/diff/20001/content/renderer/pepper/...
File content/renderer/pepper/content_decryptor_delegate.cc (right):

https://codereview.chromium.org/518523002/diff/20001/content/renderer/pepper/...
content/renderer/pepper/content_decryptor_delegate.cc:636:
static_cast<NewSessionCdmPromise*>(promise.get()));
On 2014/08/28 21:41:41, bbudge wrote:
> nit: The assignment syntax seems more common in Chrome: i.e.
> 
> NewSessionCdmPromise* session_promise =
>     static_cast< ...

Done (along with the other 2 similar instances).

[jrummell, 2014-08-28 21:52:27]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:53:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jrummell@chromium.org/518523002/40001

[commit-bot: I haz the power, 2014-08-28 23:34:09]

Committed patchset #3 (id:40001) as 11f5cdbb965bc0b83f51f5d3c92bed64c3c99def

[commit-bot: I haz the power, 2014-09-10 03:03:32]

Patchset 3 (id:??) landed as
https://crrev.com/fd0069d61b1f3281a2634bf907a96bebee7fb396
Cr-Commit-Position: refs/heads/master@{#292497}