Issue 518443003: Fix bug with Android pop-up cancelation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 518443003: Fix bug with Android pop-up cancelation. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)

Modified:
6 years, 3 months ago

Reviewers:
Ted C

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix bug with Android pop-up cancelation. BUG=407994 TEST=as in bug Committed: https://crrev.com/bee1492f297d46d159e979b09eba6b3716b00017 Cr-Commit-Position: refs/heads/master@{#292525}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Avi (use Gerrit)

avi@chromium.org changed reviewers: + tedchoc@chromium.org

6 years, 3 months ago (2014-08-28 20:01:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/518443003/1

6 years, 3 months ago (2014-08-28 20:05:11 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as f7ae9065078ee897c9dfd5eeed97dd345e146da3

6 years, 3 months ago (2014-08-29 00:54:02 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:04:28 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bee1492f297d46d159e979b09eba6b3716b00017
Cr-Commit-Position: refs/heads/master@{#292525}