Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 51843002: Remove trailing "." from message lines. (Closed)

Created:
7 years, 1 month ago by Nico
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, craigdh+watch_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, grt+watch_chromium.org, amit, sanjeevr, wez+watch_chromium.org, garykac+watch_chromium.org, feature-media-reviews_chromium.org, lambroslambrou+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, weitaosu+watch_chromium.org, ilevy-cc_chromium.org, robertshield, klundberg+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Remove trailing "." from message lines. cs.chromium.org has way fewer hits for 'message'.*\.',?$ file:gyp than for 'message'.*[^\.]',?$ file:gyp so standardize on the latter. BUG=none TEST=less ocd when watching build output NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M build/android/finalize_apk_action.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/android/write_ordered_libraries.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/system.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M build/shim_headers.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm.gyp View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/yasm/yasm_compile.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
yay / nay? The lines that annoyed me were the ones with a dot after ...
7 years, 1 month ago (2013-10-30 00:35:31 UTC) #1
scottmg
lgtm
7 years, 1 month ago (2013-10-31 17:28:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/51843002/1
7 years, 1 month ago (2013-10-31 17:35:00 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 18:08:33 UTC) #4
Message was sent while issue was closed.
Change committed as 232166

Powered by Google App Engine
This is Rietveld 408576698