Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 518423002: Reland "ui: Move ui_unittests.gyp into ui/base." (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland "ui: Move ui_unittests.gyp into ui/base." Original description from commit 63e36e6bdaa65d1152dd62f9831128c752bc0408: ui: Move ui_unittests.gyp into ui/base. ui_unittests.gyp -> ui_base_tests.gyp (follow gfx_tests.gyp pattern). ui_unittests_bundle.gypi -> ui/base/ui_base_tests_bundle.gypi ui_unittests.isolate -> ui_base_tests.isolate Add a TODO assigned to me to rename ui_unittests target to ui_base_unittests when buildbot is updated. It was reverted in commit 6297a2f1e441c46d6f8ca37a3798fe6fbdd6cc4c, because a test from ui_unittests in ios_dbg_simulator started to failing. BUG=331829, 373148, 299841, 103304 TEST=ui_unittests R=sky@chromium.org,rohitrao@chromium.org Committed: https://crrev.com/2148b92f9cc676bf2b64dc7e47ef65daac393031 Cr-Commit-Position: refs/heads/master@{#293134}

Patch Set 1 #

Patch Set 2 : fix ios? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -350 lines) Patch
M build/all.gyp View 11 chunks +10 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
A ui/base/ui_base_tests.gyp View 1 1 chunk +266 lines, -0 lines 0 comments Download
A + ui/base/ui_base_tests.isolate View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/base/ui_base_tests_bundle.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
D ui/ui_unittests.gyp View 1 chunk +0 lines, -260 lines 0 comments Download
D ui/ui_unittests.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/ui_unittests_bundle.gypi View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
tfarina
6 years, 3 months ago (2014-08-30 02:53:07 UTC) #1
sky
Did you change anything?
6 years, 3 months ago (2014-09-02 17:10:57 UTC) #2
tfarina
On 2014/09/02 17:10:57, sky wrote: > Did you change anything? Yes. See the diff between ...
6 years, 3 months ago (2014-09-02 17:15:13 UTC) #3
sky
LGTM
6 years, 3 months ago (2014-09-02 18:24:04 UTC) #4
rohitrao (ping after 24h)
Diff from patchset #1 LGTM.
6 years, 3 months ago (2014-09-03 12:16:31 UTC) #5
tfarina
Pushing to CQ, so I might not be around when this lands. Please, revert right ...
6 years, 3 months ago (2014-09-03 14:00:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/518423002/20001
6 years, 3 months ago (2014-09-03 14:01:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cca5c2c5ced99e2372e840c2b8b154231ec3feb2
6 years, 3 months ago (2014-09-03 14:46:50 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2148b92f9cc676bf2b64dc7e47ef65daac393031
Cr-Commit-Position: refs/heads/master@{#293134}

Powered by Google App Engine
This is Rietveld 408576698