Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 518353002: Remove CDM_5 (Closed)

Created:
6 years, 3 months ago by jrummell
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove CDM_5 Support As we never shipped a CDM based on CDM_5, we can remove the code. CDM_4 will be removed later, once all clients are upgraded to CDM_6. BUG=401815 TEST=existing EME tests still pass Committed: https://crrev.com/3467f088805261bdfdae2d71597e4fe6a7f3bf34 Cr-Commit-Position: refs/heads/master@{#292754}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -195 lines) Patch
M media/cdm/ppapi/cdm_adapter.h View 6 chunks +11 lines, -25 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 10 chunks +11 lines, -42 lines 0 comments Download
M media/cdm/ppapi/cdm_wrapper.h View 4 chunks +6 lines, -126 lines 0 comments Download
M media/cdm/ppapi/supported_cdm_versions.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jrummell
PTAL.
6 years, 3 months ago (2014-08-29 23:19:49 UTC) #2
xhwang
Yay! lgtm % nit Also change the title to "Remove CDM_5 support." https://codereview.chromium.org/518353002/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc ...
6 years, 3 months ago (2014-08-29 23:40:47 UTC) #3
jrummell
Thanks for the review. https://codereview.chromium.org/518353002/diff/1/media/cdm/ppapi/cdm_adapter.cc File media/cdm/ppapi/cdm_adapter.cc (right): https://codereview.chromium.org/518353002/diff/1/media/cdm/ppapi/cdm_adapter.cc#newcode1285 media/cdm/ppapi/cdm_adapter.cc:1285: // Include all previous supported ...
6 years, 3 months ago (2014-08-29 23:52:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/518353002/20001
6 years, 3 months ago (2014-08-29 23:54:34 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 01:08:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d54e537e04d8bb330325ddbc00463ade9bf6d03f
6 years, 3 months ago (2014-08-30 01:54:19 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3467f088805261bdfdae2d71597e4fe6a7f3bf34
Cr-Commit-Position: refs/heads/master@{#292754}

Powered by Google App Engine
This is Rietveld 408576698