Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: media/video/capture/mac/video_capture_device_mac.mm

Issue 518313003: Move Mac media glue code from media/video/capture/mac to media/base/mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move media glue code back to base/mac and add suitable rules in build files to compile the code for… Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/video/capture/mac/video_capture_device_mac.h" 5 #include "media/video/capture/mac/video_capture_device_mac.h"
6 6
7 #include <IOKit/IOCFPlugIn.h> 7 #include <IOKit/IOCFPlugIn.h>
8 #include <IOKit/usb/IOUSBLib.h> 8 #include <IOKit/usb/IOUSBLib.h>
9 #include <IOKit/usb/USBSpec.h> 9 #include <IOKit/usb/USBSpec.h>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/location.h" 12 #include "base/location.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/message_loop/message_loop_proxy.h" 14 #include "base/message_loop/message_loop_proxy.h"
15 #include "base/mac/scoped_ioobject.h" 15 #include "base/mac/scoped_ioobject.h"
16 #include "base/mac/scoped_ioplugininterface.h" 16 #include "base/mac/scoped_ioplugininterface.h"
17 #include "base/strings/string_number_conversions.h" 17 #include "base/strings/string_number_conversions.h"
18 #include "base/time/time.h" 18 #include "base/time/time.h"
19 #import "media/video/capture/mac/avfoundation_glue.h" 19 #import "media/base/mac/avfoundation_glue.h"
20 #import "media/video/capture/mac/platform_video_capturing_mac.h" 20 #import "media/video/capture/mac/platform_video_capturing_mac.h"
21 #import "media/video/capture/mac/video_capture_device_avfoundation_mac.h" 21 #import "media/video/capture/mac/video_capture_device_avfoundation_mac.h"
22 #import "media/video/capture/mac/video_capture_device_qtkit_mac.h" 22 #import "media/video/capture/mac/video_capture_device_qtkit_mac.h"
23 23
24 @implementation DeviceNameAndTransportType 24 @implementation DeviceNameAndTransportType
25 25
26 - (id)initWithName:(NSString*)deviceName transportType:(int32_t)transportType { 26 - (id)initWithName:(NSString*)deviceName transportType:(int32_t)transportType {
27 if (self = [super init]) { 27 if (self = [super init]) {
28 deviceName_.reset([deviceName copy]); 28 deviceName_.reset([deviceName copy]);
29 transportType_ = transportType; 29 transportType_ = transportType;
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 363
364 void VideoCaptureDeviceMac::AllocateAndStart( 364 void VideoCaptureDeviceMac::AllocateAndStart(
365 const VideoCaptureParams& params, 365 const VideoCaptureParams& params,
366 scoped_ptr<VideoCaptureDevice::Client> client) { 366 scoped_ptr<VideoCaptureDevice::Client> client) {
367 DCHECK(task_runner_->BelongsToCurrentThread()); 367 DCHECK(task_runner_->BelongsToCurrentThread());
368 if (state_ != kIdle) { 368 if (state_ != kIdle) {
369 return; 369 return;
370 } 370 }
371 int width = params.requested_format.frame_size.width(); 371 int width = params.requested_format.frame_size.width();
372 int height = params.requested_format.frame_size.height(); 372 int height = params.requested_format.frame_size.height();
373 float frame_rate = params.requested_format.frame_rate; 373 float frame_rate = params.requested_format.frame_rate;
Robert Sesek 2014/09/03 21:03:56 What's this change about?
jfroy 2014/09/03 21:17:00 I don't see any change on this line between the ba
Robert Sesek 2014/09/03 21:25:42 Ah, sorry. I was looking at an inter-patch-set dif
374 374
375 // QTKit API can scale captured frame to any size requested, which would lead 375 // QTKit API can scale captured frame to any size requested, which would lead
376 // to undesired aspect ratio changes. Try to open the camera with a known 376 // to undesired aspect ratio changes. Try to open the camera with a known
377 // supported format and let the client crop/pad the captured frames. 377 // supported format and let the client crop/pad the captured frames.
378 if (!AVFoundationGlue::IsAVFoundationSupported()) 378 if (!AVFoundationGlue::IsAVFoundationSupported())
379 GetBestMatchSupportedResolution(&width, &height); 379 GetBestMatchSupportedResolution(&width, &height);
380 380
381 client_ = client.Pass(); 381 client_ = client.Pass();
382 if (device_name_.capture_api_type() == Name::AVFOUNDATION) 382 if (device_name_.capture_api_type() == Name::AVFOUNDATION)
383 LogMessage("Using AVFoundation for device: " + device_name_.name()); 383 LogMessage("Using AVFoundation for device: " + device_name_.name());
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 if (![capture_device_ setCaptureHeight:capture_format_.frame_size.height() 573 if (![capture_device_ setCaptureHeight:capture_format_.frame_size.height()
574 width:capture_format_.frame_size.width() 574 width:capture_format_.frame_size.width()
575 frameRate:capture_format_.frame_rate]) { 575 frameRate:capture_format_.frame_rate]) {
576 ReceiveError("Could not configure capture device."); 576 ReceiveError("Could not configure capture device.");
577 return false; 577 return false;
578 } 578 }
579 return true; 579 return true;
580 } 580 }
581 581
582 } // namespace media 582 } // namespace media
OLDNEW
« media/media.gyp ('K') | « media/video/capture/mac/video_capture_device_factory_mac_unittest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698