Move Mac media glue code from media/video/capture/mac to media/base/mac

media/media.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     # Override to dynamically link the cras (ChromeOS audio) library.
     'use_cras%': 0,
     # Option e.g. for Linux distributions to link pulseaudio directly
@@ skipping 263 matching lines @@
         'base/decryptor.cc',
         'base/decryptor.h',
         'base/demuxer.cc',
         'base/demuxer.h',
         'base/demuxer_stream.cc',
         'base/demuxer_stream.h',
         'base/djb2.cc',
         'base/djb2.h',
         'base/keyboard_event_counter.cc',
         'base/keyboard_event_counter.h',
+        'base/mac/avfoundation_glue.h',
+        'base/mac/avfoundation_glue.mm',
+        'base/mac/coremedia_glue.h',
+        'base/mac/coremedia_glue.mm',
         'base/media.cc',
         'base/media.h',
         'base/media_file_checker.cc',
         'base/media_file_checker.h',
         'base/media_keys.cc',
         'base/media_keys.h',
         'base/media_log.cc',
         'base/media_log.h',
         'base/media_log_event.h',
         'base/media_posix.cc',
@@ skipping 189 matching lines @@
         'video/capture/file_video_capture_device.cc',
         'video/capture/file_video_capture_device.h',
         'video/capture/file_video_capture_device_factory.h',
         'video/capture/file_video_capture_device_factory.cc',
         'video/capture/linux/video_capture_device_factory_linux.cc',
         'video/capture/linux/video_capture_device_factory_linux.h',
         'video/capture/linux/video_capture_device_linux.cc',
         'video/capture/linux/video_capture_device_linux.h',
         'video/capture/linux/video_capture_device_chromeos.cc',
         'video/capture/linux/video_capture_device_chromeos.h',
-        'video/capture/mac/avfoundation_glue.h',
-        'video/capture/mac/avfoundation_glue.mm',
-        'video/capture/mac/coremedia_glue.h',
-        'video/capture/mac/coremedia_glue.mm',
         'video/capture/mac/platform_video_capturing_mac.h',
         'video/capture/mac/video_capture_device_avfoundation_mac.h',
         'video/capture/mac/video_capture_device_avfoundation_mac.mm',
         'video/capture/mac/video_capture_device_factory_mac.h',
         'video/capture/mac/video_capture_device_factory_mac.mm',
         'video/capture/mac/video_capture_device_mac.h',
         'video/capture/mac/video_capture_device_mac.mm',
         'video/capture/mac/video_capture_device_qtkit_mac.h',
         'video/capture/mac/video_capture_device_qtkit_mac.mm',
         'video/capture/video_capture_device.cc',
@@ skipping 364 matching lines @@
               '$(SDKROOT)/System/Library/Frameworks/AudioToolbox.framework',
               '$(SDKROOT)/System/Library/Frameworks/AudioUnit.framework',
               '$(SDKROOT)/System/Library/Frameworks/CoreAudio.framework',
               '$(SDKROOT)/System/Library/Frameworks/CoreMIDI.framework',
               '$(SDKROOT)/System/Library/Frameworks/CoreVideo.framework',
               '$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
               '$(SDKROOT)/System/Library/Frameworks/QTKit.framework',
             ],
           },
         }],
+        ['OS == "ios" and _toolset != "host"', {
+          'sources/': [
+            # Pull in specific Mac files for iOS (which have been filtered out
+            # by file name rules).
+            ['include', '^base/mac/avfoundation_glue\\.'],
+            ['include', '^base/mac/coremedia_glue\\.'],
+          ],
+          'link_settings': {
+            'libraries': [
+              '$(SDKROOT)/System/Library/Frameworks/AudioToolbox.framework',

[Robert Sesek, 2014/09/03 21:03:56]

This is a number of libraries. Are all of these necessary?

[jfroy, 2014/09/03 21:17:00]

I am matching the Mac frameworks. None of those are necessary for the glue code
files, but presumably an iOS binary will need those when incorporating the
media/base component.

I can remove this chunk from this CL and submit it separately. The purpose of
relocating the glue code is because it will be used by other other than the Mac
video capture implementation. Modifying media build files to better support iOS
is a separate concern.

[Robert Sesek, 2014/09/03 21:25:42]

Unless you can say definitely whether all of these are needed, I'd hold off.
It's not good to add unnecessary linkage, and I don't think someone would come
back and clean up the unnecessary ones later.

+              '$(SDKROOT)/System/Library/Frameworks/AudioUnit.framework',
+              '$(SDKROOT)/System/Library/Frameworks/CoreAudio.framework',
+              '$(SDKROOT)/System/Library/Frameworks/CoreMedia.framework',
+              '$(SDKROOT)/System/Library/Frameworks/CoreMIDI.framework',
+              '$(SDKROOT)/System/Library/Frameworks/CoreVideo.framework',
+              '$(SDKROOT)/System/Library/Frameworks/OpenGLES.framework',
+            ],
+          },
+        }],
         ['OS=="win"', {
           'link_settings':  {
             'libraries': [
               '-lmf.lib',
               '-lmfplat.lib',
               '-lmfreadwrite.lib',
               '-lmfuuid.lib',
             ],
           },
           # Specify delayload for media.dll.
@@ skipping 835 matching lines @@
                   ],
                 }],
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }