Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3929)

Unified Diff: chrome/browser/enumerate_modules_model_win.h

Issue 5183007: Polish the Enumerate Modules implementation a bit.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/enumerate_modules_model_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enumerate_modules_model_win.h
===================================================================
--- chrome/browser/enumerate_modules_model_win.h (revision 66756)
+++ chrome/browser/enumerate_modules_model_win.h (working copy)
@@ -81,6 +81,8 @@
string16 digital_signer;
// The help tips bitmask.
RecommendedAction recommended_action;
+ // The duplicate count within each category of modules.
+ int duplicate_count;
// Whether this module has been normalized (necessary before checking it
// against blacklist).
bool normalized;
@@ -141,7 +143,7 @@
void EnumerateShellExtensions();
// Enumerate all registered Winsock LSP modules.
- void EnumerateWinsockModule();
+ void EnumerateWinsockModules();
// Reads the registered shell extensions found under |parent| key in the
// registry.
@@ -151,6 +153,11 @@
// information using the location field of the module.
void PopulateModuleInformation(Module* module);
+ // Checks the module list to see if a |module| of the same type, location
+ // and name has been added before and if so, increments its duplication
+ // counter. If it doesn't appear in the list, it is added.
+ void AddToListWithoutDuplicating(const Module&);
+
// Builds up a vector of path values mapping to environment variable,
// with pairs like [c:\windows\, %systemroot%]. This is later used to
// collapse paths like c:\windows\system32 into %systemroot%\system32, which
« no previous file with comments | « no previous file | chrome/browser/enumerate_modules_model_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698